Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/post launch docs feedback and clarifications #129

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 8, 2024

Related Issue

N / A

Summary of Changes

  1. Added proper mini Table of Contents for Plugins and Content as data landing sections
  2. Make custom imports usage script more generic (for example, the current location recommended does not work for pnpm)
  3. Make custom imports script less generic to account for different package managers
  4. Make Prerendering requirement of using a default export clearer for Scripts section
  5. Document pnpm special instructions for shamefully-hoist option

TODO

  1. Looks like I missed a patch that causes certain table of contents cases to render one less heading than there should be and now a heading is missing on the Plugins section page - table of contents sometimes missing first heading tag greenwood#1305
    Screenshot 2024-11-08 at 1 45 38 PM
  2. validate more generic custom imports loader location

@thescientist13 thescientist13 added docs Greenwood specific content like docs and guides needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Nov 8, 2024
@thescientist13 thescientist13 self-assigned this Nov 8, 2024
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 1905ffd
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67328471c3d2340008412006
😎 Deploy Preview https://deploy-preview-129--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 added fast follow Carryovers from the launch milestone and removed needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Nov 8, 2024
@thescientist13 thescientist13 marked this pull request as ready for review November 8, 2024 22:05
@thescientist13 thescientist13 merged commit f83ba84 into main Nov 11, 2024
5 checks passed
@thescientist13 thescientist13 deleted the docs/post-launch-docs-feedback branch November 11, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides fast follow Carryovers from the launch milestone
Projects
Development

Successfully merging this pull request may close these issues.

1 participant