-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content/issue 33 guides pages #94
Conversation
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Internal Feedback Notes
|
Browser TestingIn regards to browser compat, everything is looking good except for nesting, at least in my version of Safari (17.0) presumable, lots of styles are not quite right. However looks good for everything, including Safari TP FirefoxSafari TPFor nesting specifically, it looks like for Safari it's not supported <= 17.x, but that only has 1% of browser share iOSOn iOS the popover dropdown color is not styled, so let me see if I can handle that, but not a big deal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few more tweaks based on internal design feedback and so I think this is a good first pass on this content and layout overall. We'll definitely get a good second pass at this when we the #31 anyway.
Excited to get this one in, thanks for all the feedback and good suggestions! 😮💨
Related Issue
resolves #33
Summary of Changes
TODO
active ToC highlighting- did rollover highlighting for nowand / or sticky or scrolling effectDockerCloudflareAWSNice to have / new issue
.heading-box
componentbasic unit testingThoughts / Questions
Upstreams
toc
handling from usingshift
title
not populating as active frontmatter?route
guard in side-nav component) - top level attributes returning as undefined wcc#165<app-heading-box>
component, needed to patch in feature/WCC v0.15.0 and HTML Web Components greenwood#1284Location
headers changes in Website redesign, branding, and long term structure greenwood#978/guides/cloudflare-workers-deployment/
->/guides/hosting/cloudflare/
/guides/firebase/
-> 404/guides/github-pages/
->/guides/hosting/github/
/guides/netlify-deploy/
(netlify) ->/guides/hosting/netlify/
/guides/netlify-cms/
(netlify???) -> 404/guides/now/
(vercel) ->/guides/hosting/vercel/
/guides/s3-cloudfront/
(AWS) ->/guides/hosting/aws/
/guides/theme-packs/
->/guides/tutorials/theme-packs/
/getting-started/
->/guides/getting-started/