-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas model #13
Conversation
eldond
commented
Sep 25, 2023
- Adds a simple model for converting a gas command in V(t) into a flow rate vs. time. Includes slightly nonlinear equilibrium flow(voltage) as well as dead time and first order lag between flow and command.
- The instant gas model that goes from equilibrium flow(voltage) is taken from DIII-D.
- The dynamics model is just FOPDT.
- Model is sensitive to gas species.
- All tuning is made up or copied from DIII-D and not valid for SPARC; these are just sample data that have to be fixed up later.
- Should be adequate for setting up any workflow that needs an actuator model.
- Close Make a simple actuator model for use in testing #6
- Gas model is based on DIII-D valve flow(command) at steady state - Dynamics from First-Order Plus Dead Time - Default tuning is copied from DIII-D or made up - Model is sensitive to gas species - Model should be valid for building workflows using sample data
Force push was to rebase and squash all the cleanup/fix commits together. The log must be clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mainly like comments or changes in code in the first two comments I made.
For the comments marked minor/optional/suggestions, please feel free to mark them resolve without any changes.