Adding option to specify cell subset index #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be accepted with ProjectTorreyPines/SOLPS2imas.jl#30 and ProjectTorreyPines/FusionSyntheticDiagnostics.jl#23
With SOLPS2IMAS being able to read EIRENE grid that displaces B2.5 grid to grid subset -5, the SD4SOLPS function that extrapolates B2.5 data into core using equilibrium profile should have an option of specifying the cell_subset_index. This PR provides that.
Note however, that all_cells_subset index in function pick_mesh_ext_starting_points has not been changed. It is not clear right now what we will do with this function and I propose to make changes to this function in a different PR.