Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qt crash #502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix qt crash #502

wants to merge 2 commits into from

Conversation

Cimbali
Copy link

@Cimbali Cimbali commented Oct 23, 2024

This PR fixes #500 by:

  • adding the import that defines ColorImage (an undocumented QtQuick internal) to the files that use it. The better fix would be to use a documented way of displaying images, but this is the simplest fix.
  • Renames popupType to popupPrio as it is used for priority of popups, and because popupType is a (final) property of QtQuick popups since 6.8

Note that:

  • Fixes are trivial
  • Any platforms running Qt 6.8 are affected, so not Arch-specific as claimed in Fails to start with Qt 6.8 #500 (neither OpenSUSE-specific, Ubuntu non-LTS, Fedora 41, Fedora Rawhide, etc. etc. -- all up-to-date platforms are affected by the bug, the others will be in time when updating Qt)
  • Qt 6.8 is marked as LTS so there is even more value in fixing this early on
  • Seen the dismissive answers on Fails to start with Qt 6.8 #500 😢, I share this more for package maintainers and self-builders than hoping it will get merged. Feel free to use these patches until upstream provides their own fixes.

@Antiz96
Copy link

Antiz96 commented Oct 24, 2024

@Cimbali Thanks a lot!

I can confirm these patches work as intended (tested on Arch Linux). I backported them to the Arch's protonmail-bridge package while waiting for them to be merged & released here (or for upstream to provide their own fixes at some point).

@joekm
Copy link

joekm commented Oct 24, 2024

Thanks for the patch. Also felt bad for the developers getting all that whining from a few Arch users over such a trivial matter. I. E. - just run it without the QT interface until 6.8 becomes more commonplace. This kind of thing is "par for the course" for Arch (or any distro close to "bleeding edge"), and the Proton developers had an easy work around already in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to start with Qt 6.8
3 participants