Develop

[JoeMatt]

PR Type

Enhancement, Bug fix

---

Description

• Enhanced the SwiftGen plugin to support parsing targets from arguments and added DERIVED_SOURCES_DIR to the environment variables.
• Refactored the logic to check for swiftgen.yml configuration files within targets.
• Added support for Xcode project integration, including validation for SwiftGen configurations in Xcode targets.
• Introduced conditional compilation for Xcode-specific code to ensure compatibility.

---

Changes walkthrough 📝

Relevant files

Enhancement

Plugin.swift Enhance SwiftGen plugin to support target parsing and additional environment variables Plugins/SwiftGen-Generate/Plugin.swift Added support for parsing targets from arguments. Included DERIVED_SOURCES_DIR in the environment variables. Refactored logic to check for swiftgen.yml configuration in targets. +26/-17  Plugin.swift Add Xcode project support and validation for SwiftGen configurations Plugins/SwiftGenPlugin/Plugin.swift Added support for Xcode project integration. Implemented validation for SwiftGen configurations in Xcode targets. Introduced conditional compilation for Xcode-specific code. +63/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Error Handling The method performCommand lacks error handling for file operations and SwiftGen command execution. Consider adding appropriate error handling to prevent runtime crashes and provide more informative error messages to the user. Code Duplication The logic for appending 'swiftgen.yml' and checking if the file exists is repeated in multiple places. Consider refactoring this into a separate method to reduce code duplication and improve maintainability.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add error handling for missing required tools Add error handling for the case where the 'swiftgen' tool is not found in the system, to prevent runtime crashes. Plugins/SwiftGen-Generate/Plugin.swift [13] -let swiftgen = try context.tool(named: "swiftgen") +guard let swiftgen = try? context.tool(named: "swiftgen") else { + throw PluginError.toolNotFound("SwiftGen tool is required but not found.") +} Apply this suggestion Suggestion importance[1-10]: 9 Why: Adding error handling for the case where the 'swiftgen' tool is not found is crucial to prevent runtime crashes. This suggestion addresses a potential bug and improves the robustness of the code.	9
Maintainability	Refactor repeated code into a helper function for better maintainability Replace the repeated code for appending 'swiftgen.yml' and checking file existence with a helper function to improve code maintainability and reduce redundancy. Plugins/SwiftGen-Generate/Plugin.swift [16-30] -let configuration = context.package.directory.appending("swiftgen.yml") +let configuration = getConfigurationPath(context.package.directory) if fileManager.fileExists(atPath: configuration.string) { try swiftgen.run(configuration, environment: env(context: context)) } ... -let configuration = target.directory.appending("swiftgen.yml") +let configuration = getConfigurationPath(target.directory) if fileManager.fileExists(atPath: configuration.string) { try swiftgen.run(configuration, environment: env(context: context, target: target)) } Suggestion importance[1-10]: 8 Why: This suggestion effectively reduces code redundancy and improves maintainability by refactoring repeated code into a helper function. It correctly identifies and addresses the repeated code segments.	8
Enhancement	✅ Improve the robustness of command line parsing Suggestion Impact: The commit includes a new function `parseTargets` that implements a more robust method to parse command line arguments, specifically checking for the index range, which aligns with the intention of the suggestion. code diff: + func parseTargets(_ arguments: [String]) -> [String] { + var result = [String]() + for (i, arg) in arguments.enumerated() where arg == "--target" { + let valueIdx = i + 1 + if valueIdx < arguments.count { + result.append(arguments[valueIdx]) + } + } + return result Use a more robust method to parse command line arguments to avoid potential index out of range errors. Plugins/SwiftGen-Generate/Plugin.swift [48-52] -for (i, arg) in arguments.enumerated() where arg == "--target" { - let valueIdx = i + 1 - if valueIdx < arguments.count { - result.append(arguments[valueIdx]) - } +for (i, arg) in arguments.enumerated() where arg == "--target" && i + 1 < arguments.count { + result.append(arguments[i + 1]) } Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion improves the robustness of command line argument parsing by preventing potential index out of range errors. It is a valuable enhancement but not critical.	7
Best practice	Use constants instead of magic strings for better code maintainability Avoid using magic strings directly in the code. Define them as constants to improve code readability and maintainability. Plugins/SwiftGen-Generate/Plugin.swift [16-19] -let configuration = context.package.directory.appending("swiftgen.yml") +let swiftGenConfigFile = "swiftgen.yml" +let configuration = context.package.directory.appending(swiftGenConfigFile) if fileManager.fileExists(atPath: configuration.string) { try swiftgen.run(configuration, environment: env(context: context)) } Apply this suggestion Suggestion importance[1-10]: 6 Why: Using constants instead of magic strings improves code readability and maintainability. While beneficial, this change is more about best practices and does not address any critical issues.	6