Fix Exalt 5 Bonus Reward #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix global currentSingChallenge value after reloads
syntax issues
typos, syntax
syntax
|
The exalt bonus is properly applied when enabling an exalt challenge as G.currentSingChallenge is properly set, but if the game reloads, all the G values revert to the defaults, which changes it back to undefined, incorrectly calculating the bonus as 0. This repopulates the value correctly, but could just as easily not use this value and rely on the player values directly. This fix seems like less change overall in short term. |
use tag instead of key directly
KhafraDev
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix global currentSingChallenge value after reloads