Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the version of msys2 included in the runner #129

Closed
wants to merge 1 commit into from

Conversation

JoeSchiff
Copy link
Contributor

@JoeSchiff JoeSchiff commented Nov 25, 2024

I have been getting this error on the Windows runner:
ERROR: aom >= 2.0.0 not found using pkg-config

I think it is because the paths in PKG_CONFIG_PATH are getting messed up.

ffbuild/config.log says:
Can't find >=.pc in any of /c/cibw/vendor/lib/pkgconfig C \cibw\vendor\lib\pkgconfig;D \a\_temp\msys64\mingw64\lib\pkgconfig;D \a\_temp\msys64\mingw64\share\pkgconfig /usr/lib/pkgconfig /usr/share/pkgconfig

@JoeSchiff
Copy link
Contributor Author

I got the builds to pass in my fork. I'm just waiting for some more tests to finish. I'll have more info tomorrow

@JoeSchiff
Copy link
Contributor Author

Notes:

Location of aom.pc:
/c/cibw/vendor/lib/pkgconfig

This message ERROR: aom >= 2.0.0 not found using pkg-config still occurs even when erasing 'PKG_CONFIG_PATH' env var and setting it to:
'PKG_CONFIG_PATH': '/c/cibw/vendor/lib/pkgconfig'

Location of ffbuild/config.log:
/d/a/pyav-ffmpeg/pyav-ffmpeg/build/ffmpeg/build/ffbuild/config.log

msys2 docs:
https://github.com/msys2/setup-msys2?tab=readme-ov-file#release
https://www.msys2.org/docs/filesystem-paths/
https://www.msys2.org/docs/pkgconfig/

Content of aom.pc:

# libaom pkg-config.
prefix=C:/cibw/vendor
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

Name: aom
Description: Alliance for Open Media AV1 codec library v3.2.0.
Version: 3.2.0
Requires:
Conflicts:
Libs: -L${libdir} -laom
Libs.private: -lm -lpthread
Cflags: -I${includedir}

@JoeSchiff JoeSchiff marked this pull request as ready for review November 25, 2024 15:03
@JoeSchiff
Copy link
Contributor Author

I'm still testing environ variables.

msys2 release: false. Build passes with:
'PKG_CONFIG_PATH': '/c/cibw/vendor/lib/pkgconfig:C:\\msys64\\mingw64\\lib\\pkgconfig;C:\\msys64\\mingw64\\share\\pkgconfig'

msys2 release: true. Build fails with:
'PKG_CONFIG_PATH': '/c/cibw/vendor/lib/pkgconfig:D:\\a\\_temp\\msys64\\mingw64\\lib\\pkgconfig;D:\\a\\_temp\\msys64\\mingw64\\share\\pkgconfig'

@JoeSchiff
Copy link
Contributor Author

After removing the aom package from build-ffmpeg.py, the error persists, but with the dav1d package instead. When I removed dav1d, the error persists with the next package. So, I think this has nothing to do with aom. aom is just the first package listed.

@JoeSchiff JoeSchiff changed the title Prevent libaom error Use the version of msys2 included in the runner Nov 25, 2024
@WyattBlue
Copy link
Member

If you released this commit on my latest commit, and removed disabled aom on Windows. I'll merge this PR

@JoeSchiff
Copy link
Contributor Author

Yeah, I removed aom only temporarily to test what would happen. My bad, I should have made that clearer.

This commit includes only what was grabbed from a git clone yesterday and

      - uses: msys2/setup-msys2@v2
          ...
          release: false

@WyattBlue
Copy link
Member

Thanks for your help! I'm going to use my commit though because it has a cleaner git history 3c9f47a

@WyattBlue WyattBlue closed this Nov 26, 2024
@JoeSchiff
Copy link
Contributor Author

Sounds good. Glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants