Fix Windows pkg-config issue #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ffmpeg package build has been failing with this error:
ERROR: aom >= 2.0.0 not found using pkg-configI was able to track the source of the problem to this line in ffmpeg's configure file:
https://github.com/FFmpeg/FFmpeg/blob/56419fd096c55c646fc56d8dde522e32079c907c/configure#L1523
For some reason, when
$pkg_versiongets evaluated the spaces are not handled correctly. I have no idea why this issue has surfaced only recently.Putting quotes around the variable seems to solve it. It's not an ideal solution, but it works.
I'll look into upstreaming this change into ffmpeg. Do you have any experience with that?