Bundle Secure Reliable Transport protocol #137
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WyattBlue How does this look to you? Are there any changes you would like me to make? |
|
@JoeSchiff Like I've noted in my "review", your changes mandate MacOS 13/14 be used. Dropping MacOS 11 and 12 with no warning. Even if this is noted in the changelog, not enough people read these. I'm sure someone will be irrationality angry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyAV-Org/PyAV#1503
I had some trouble with openssl. If I installed ssl in the yml file, it would cause a conflict with nettle. So I ended up installing it after nettle was built (during srt package build).
Most of the other changes are to help Windows find files.