Skip develop_cffi_pure

PyO3 · Oct 19, 2024 · 314cc70 · 314cc70
1 parent 29d3c55
commit 314cc70
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -39,9 +39,9 @@ jobs:
       matrix:
         os:
           - ubuntu-latest
-          #- macos-13
-          #- macos-14
-          #- windows-latest
+          - macos-13
+          - macos-14
+          - windows-latest
         python-version:
           - '3.9'
           - '3.13'
@@ -304,6 +304,7 @@ jobs:
     container: quay.io/pypa/${{ matrix.manylinux }}_x86_64
     steps:
       - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
       - uses: actions/download-artifact@v4
         with:
           name: maturin-build
@@ -381,7 +382,7 @@ jobs:
         with:
           name: maturin-build
           path: bin
-      - run: chmod +x bin/maturin-build
+      - run: chmod +x bin/maturin
       - uses: dtolnay/rust-toolchain@stable
         with:
           targets: ${{ matrix.platform.target }}

diff --git a/tests/run.rs b/tests/run.rs
@@ -120,8 +120,8 @@ fn develop_pyo3_mixed_src_layout() {
 #[test]
 fn develop_cffi_pure() {
     let python_implementation = test_python_implementation().unwrap();
-    if cfg!(windows) && env::var("GITHUB_ACTIONS").is_ok() && python_implementation == "pypy" {
-        // PyPy on Windows hangs on cffi test sometimes
+    if env::var("GITHUB_ACTIONS").is_ok() && python_implementation == "pypy" {
+        // TODO: PyPy hangs on cffi test sometimes
         return;
     }
     handle_result(develop::test_develop(