Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test matrix and remove merge queue #2268

Merged
merged 32 commits into from
Oct 19, 2024
Merged

Simplify test matrix and remove merge queue #2268

merged 32 commits into from
Oct 19, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 18, 2024

Currently, PR testing is a two-step process: First the regular PR tests, then the merge group tests. The test suite is flaky and test jobs take a long with limited parallelism, which means you can make a simple PR and 2h later get the notification that the PR failed due to an unrelated (and potentially temporary) error. There were several parts not passing when ran as a regular CI job. CI was failing a lot a blocking effective development. This PR radically simplifies the CI setup.

  • Remove debian package: maturin is shipped with ubuntu 24.04
  • Remove delete comments actions: github fixed this on their side
  • Merge lint jobs and move to the test jobs: Remove the CI matrix a bit
  • Only test minimum and maximum Python versions (3.9 to 1.13, 3.8 is EOL and 3.13 is out): Reduce the number of parallel jobs
  • Deactivate jobs that only time out
  • Remove cache-to from docker test: We don't need to cache every docker test build
  • Remove the merge queue: Run all tests immediately. We don't have the volume that we would need merge groups
  • Inline the test matrix: Without the merge queue, we don't need an extra job to compute the matrix or select jobs
  • Build maturin (statically linked) in separate job and reuse the binary
  • Fix dockerfile lints

By additionally changing the required jobs, we can switch to "merge when ready" so you don't need to return to a PR to check if CI is ready.

@konstin konstin merged commit e420f9b into main Oct 19, 2024
33 of 35 checks passed
@konstin konstin deleted the konsti/ci-overhaul branch October 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant