Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run nox -s clippy-all against free-threaded build in CI #4639

Closed
wants to merge 1 commit into from

Conversation

ngoldbaum
Copy link
Contributor

While working on #4588 I realized the clippy CI job doesn't run against the free-threaded build. Rather than adjusting the clippy CI job to install a free-threaded Python, I thought it was easier to update the existing free-threaded test to do this.

@ngoldbaum ngoldbaum added the CI-skip-changelog Skip checking changelog entry label Oct 22, 2024
@ngoldbaum ngoldbaum force-pushed the free-threaded-clippy branch from 1e875fa to c4b24cf Compare October 23, 2024 22:11
@davidhewitt
Copy link
Member

I don't think this is needed:

  • the clippy-all job is to run over (almost) all Python versions, and it's suuuper slow
  • the clippy job is already run as part of the nox command just below (clippy in in the default sessions)

So clippy should already be running and this is just redundant extra work, I believe. (Covered by the normal clippy ubuntu job.)

@ngoldbaum
Copy link
Contributor Author

OK, fair enough. Thanks for explaining.

@ngoldbaum ngoldbaum closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants