Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 0.23.3 #4745

Merged
merged 10 commits into from
Dec 3, 2024
Merged

release: 0.23.3 #4745

merged 10 commits into from
Dec 3, 2024

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Nov 29, 2024 •
edited
Loading

Staging branch for the 0.23.3 patch release.

So far this includes #4733. I have a couple other things I think worth resolving before release:

@davidhewitt
Copy link
Member Author

Maybe also #4738 (reply in thread)

@davidhewitt
Copy link
Member Author

Segmentation fault in pydantic-core seems to have been attributable to use of PyUnicode_DATA in jiter. So the bug is "resolved" at least as far as downstream is concerned, but I think makes me worried about testing more architectures better in CI. I opened #4754, though that doesn't necessarily need to block the patch release.

Link failures on aarch64 windows, will investigate those too. pydantic/pydantic-core#1570 (comment)

I think the link failures are worth resolving in the patch, if it's trivial to do so.

@davidhewitt
Copy link
Member Author

Need to update this to pull #4753 (thanks @Icxolu) and #4749.

@davidhewitt
Copy link
Member Author

As per #4757 I think this just became critically urgent. Will update here now.

@davidhewitt
fix PYO3_CONFIG_FILE env var not requesting rebuilds (#4758)
5d7733c 
* fix `PYO3_CONFIG_FILE` env var not requesting rebuilds

* test and newsfragment

* fix clippy

* relax assertion
@davidhewitt
release: 0.23.3
f77fa7c
@davidhewitt davidhewitt marked this pull request as ready for review December 3, 2024 21:24
@davidhewitt
Copy link
Member Author

Release is now prepared; assuming CI turns fully green I intend to proceed to merge and release immediately after. I will follow up by yanking 0.23.0 through 0.23.2 and file a security advisory, I guess.

@davidhewitt davidhewitt merged commit b5599dc into release-0.23 Dec 3, 2024
77 checks passed
@davidhewitt davidhewitt deleted the release-0.23.3 branch December 3, 2024 22:31
@davidhewitt
Copy link
Member Author

Release is now live on crates.io so users should increasingly be pulling it; it's late here so I am going to head to sleep and follow up with the yanking / advisory / GitHub release tomorrow.

@alex
Copy link
Contributor

alex commented Dec 3, 2024 via email

This was referenced Dec 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-build-full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidhewitt @alex @Icxolu @kemingy