Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lints in pyo3-benches #4770

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix lints in pyo3-benches #4770

merged 1 commit into from
Dec 6, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Dec 5, 2024

Fixes a few lints within pyo3-benches

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Dec 5, 2024
davidhewitt
davidhewitt approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up! LGTM with just a few suggestions.

pyo3-benches/benches/bench_set.rs Outdated Show resolved Hide resolved
pyo3-benches/benches/bench_call.rs Outdated Show resolved Hide resolved
@Icxolu Icxolu added this pull request to the merge queue Dec 6, 2024
Merged via the queue into PyO3:main with commit 6b4dc78 Dec 6, 2024
46 checks passed
@Icxolu Icxolu deleted the benches branch December 6, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @davidhewitt