Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds power supply errors to the string of quads and fixes memory leak in space charge with MPI. #33

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

shishlo
Copy link
Contributor

@shishlo shishlo commented Nov 4, 2024

The method that set power supply (PS) errors to the string of quads (quads that use the same PS) was added.

…nacLatticeFactory is modified to read XML lattice files with solenoid nodes. The example in examples/ESS_Linac/linac_solenoid_test was created to compare TEAPOT lattice and Linac style tracking through solenoids.
@azukov
Copy link
Member

azukov commented Nov 8, 2024

this needs to be split into two PRs:

  • more testing from @juanfem fro solenoid addition
  • errors we can merge

…unch* bunch) the internal 2 arrays of 7 elements each were borrowed from BufferStore::getBufferStore(), but they were never returned back. It created a constant memory growth and slow down the whole process. This situation was developed only for total_macrosize equals to zero. Fixed.
@azukov
Copy link
Member

azukov commented Dec 12, 2024

I will leave it in one PR but will change its name.
Fixes #39

@azukov azukov changed the title The method that set power supply (PS) errors to the string of quads. Adds power supply errors to the string of quads and fixes memory leak in space charge with MPI. Dec 12, 2024
@azukov azukov merged commit 7dfc171 into PyORBIT-Collaboration:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants