Skip to content

Commit

Permalink
Put quotes around versions in pip install cmd lnie
Browse files Browse the repository at this point in the history
Signed-off-by: Arthit Suriyawongkul <[email protected]>
  • Loading branch information
bact committed Oct 27, 2024
1 parent 89911b0 commit 1351a02
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip==24.0 setuptools<65
python -m pip install --upgrade "pip==24.0" "setuptools<65"
pip install wheel twine
python setup.py sdist bdist_wheel
- name: Publish a Python distribution to PyPI
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
env:
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL: True
run: |
python -m pip install --upgrade pip==24.0 setuptools<65
python -m pip install --upgrade "pip==24.0" "setuptools<65"
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install -r https://raw.githubusercontent.com/PyThaiNLP/pythainlp/dev/docker_requirements.txt
pip install pythainlp[full]
python -m nltk.downloader omw-1.4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
conda activate pythainlpwork310
conda info
conda list
python -m pip install --upgrade pip==24.0 setuptools<65
python -m pip install --upgrade "pip==24.0" "setuptools<65"
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install -r docker_requirements.txt
conda install -y -c conda-forge protobuf
pip install pytest coverage coveralls
Expand All @@ -70,7 +70,7 @@ jobs:
- name: Install dependencies
shell: bash -l {0}
run: |
python -m pip install --upgrade pip==24.0 setuptools<65
python -m pip install --upgrade "pip==24.0" "setuptools<65"
pip install pytest coverage coveralls
conda install -c conda-forge icu
conda install -c conda-forge pyicu
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip==24.0 setuptools<65
python -m pip install --upgrade "pip==24.0" "setuptools<65"
pip install pytest coverage coveralls
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install -r docker_requirements.txt
pip install .[full]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
env:
SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL: True
run: |
python -m pip install --disable-pip-version-check --user --upgrade pip==24.0 setuptools<65
python -m pip install --disable-pip-version-check --user --upgrade "pip==24.0" "setuptools<65"
python -m pip --version
python -m pip install pytest coverage coveralls
conda install -y -c conda-forge fairseq
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ COPY . .

RUN apt-get update && apt-get install -y --no-install-recommends build-essential libicu-dev libicu63 pkg-config && rm -rf /var/lib/apt/lists/*

RUN pip3 install --upgrade pip==24.0 setuptools<65
RUN pip3 install --upgrade "pip==24.0" "setuptools<65"
RUN if [ -f docker_requirements.txt ]; then pip3 install -r docker_requirements.txt; fi
RUN pip3 install -e .[full] && pip3 cache purge

0 comments on commit 1351a02

Please sign in to comment.