-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhayaThaiBERT engine with new features [WIP] #873
Conversation
refactor code and add test cases
Hello @pavaris-pm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-11 14:00:19 UTC |
@bact @wannaphong i've already add all features that i've been found from phayathaibert into the source code and already fix pep8 format. As of today, here is new features added
Upcoming features that can be added soon (future PR)
According to this, i think that adding these 4 completed features first, and the upcoming features (e.g. word correction) can be added later with the next PR because it is better to bring the state-of-the-art Thai encoder based model into production asap. With that, you can review this PR and suggest for further development of them. If you're ok with this, you can approve and merge it krub. |
@MpolaarbearM kindly inform here that co-authored commit already made krub. You can check it 😄 |
There were few error test suite (not related to your PR). |
Roger that. I'll do it krub. |
@bact I'm done with syncing already |
Use UPPERCASE for constant
Kudos, SonarCloud Quality Gate passed! |
What does this changes
According to #868, i have made a new PR by added new folder named
phayathaibert
since it is a new Thai language model, with that, i decided to treat it to be the same as we treatwangchanberta
because it also has their own folder as well. Apart from introducing a new model, i currently made an experiment and added new features into pythainlp including its test cases as well (you can see the list in this PR description). Clearly note here that this PR also solved the unsync forked version in #871 as well.Will resolve #871 and fix #868.
List of new added features from PhayaThaiBERT [WIP] 🚧 👷🏻♂️
Here is the task which I found that PhayaThaiBERT can be integrated in PyThaiNLP after reading a paper. The list below here is the current progress (check mark means that I already added in the source code and will ask for your review after i complete all of them krub):
Upcoming features that can be added soon (futurePR)
etc ... (I will keep add more into the list based on what I have found during an experiment)
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.