-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong/incompatible types, code readability #884
Conversation
- `Trie` cannot be `None`, change to `Trie([])` - `not Trie([])` is `True` and can be used to test if a `custom_dict` is given - `Iterable` cannot be `None, change to `[]` - `not []` is `True` and can be used to test if a `custom_dict` is given - Make `Trie` an `Iterable` - General formatting and imports sorting - Add SPDX license info
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-07 12:53:55 UTC |
Kudos, SonarCloud Quality Gate passed! |
Trie
cannot beNone
, change toTrie([])
not Trie([])
isTrue
and can be used to test if acustom_dict
is givenIterable
cannot beNone, change to
[]`not []
isTrue
and can be used to test if acustom_dict
is givenTrie
anIterable