Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to Python 3.10 #934

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

Update CI to Python 3.10 #934

wants to merge 27 commits into from
+147 −528

Conversation

bact
Copy link
Member

@bact bact commented Oct 27, 2024 •
edited
Loading

What does this changes

  • Update Python version in CI workflows to 3.10 (torch==1.x requires Python >=3.7,<3.11)
  • Update dependencies to its latest minor upgrade (e.g. 5.2 -> 5.10)

To fix #930

@bact
Update CI to Python 3.12
a9217b5 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the infrastructure build process, configuration, GitHub Actions label Oct 27, 2024
@bact
Remove backports.zoneinfo (already in 3.9)
1a41072 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Upgrade PyYAML
92f2b31 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use Python 3.10 because Torch 1.x
d6a4114 
torch==1.x Requires-Python >=3.7,<3.11

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove redundant pip install
e24713f 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
specify the patch version for Python setup on Ubuntu
c851a4a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use ubuntu-22.04
6850498 
Due an issue here actions/setup-python#401, cannot use ubuntu-24.04

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use Python 3.9 on Ubutnu
7fa39c4 
Due an issue here actions/setup-python#401

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Try using container for Python 3.10 on Ubuntu isntead
c02d387 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
3.10 has to be inside quote as "3.10"
ab9d819 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use pip==24.0
3b5020a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use setuptools<65
48085e7 
Follow https://stackoverflow.com/questions/79063140/modulenotfounderror-no-module-named-distutils-msvccompiler-when-trying-to-ins

Signe-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact changed the title Update CI to Python 3.12 Update CI to Python 3.10 Oct 27, 2024
@bact
Use setuptools<65
89911b0 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the dependencies Pull requests that update a dependency file label Oct 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infrastructure build process, configuration, GitHub Actions
Projects
PyThaiNLP
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI away from the unsupported Python 3.8
1 participant
@bact