-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments the deform.load since it's documented that the HTML should call it #156
Conversation
…all it. Since this script needs to be loaded before the HTML, using `$` here impedes that we place the jquery script at the end of the page.
While I don't know enough to say whether the substantive part of the change is correct (removing the deferred call to 'deform.load()', I do know that we should not check it in commented-out: either it stays or it goes. |
@tseaver That's right. IMO it should go away. I will remove the comments so that discussion happens here. |
I think the call to deform.load needs to stay in deform.js, and the docs need to be changed to say to not call it via the HTML. |
@mcdonc I think leaving this call reduces your options as programmer. The documentation should be amended not only by removing the need to call |
Hi, Do you think is this going to be merged? I find my self struggling with this three lines every time I update/deploy a system that happens to use the I'm thinking if the right way would be to provide a switch/middleware to inject the |
Might I suggest a change like I mentioned in #215. It allows things to default to the current implementation, but provides a hook to allow people to load jquery at the end of a document. |
I'm closing this PR in favor of pull request #229, which is nicer. |
Since the
deform.js
script needs to be loaded before the HTML, using$
here impedesthat we place the jquery script at the end of the page.
Furthermore is documented in http://docs.pylonsproject.org/projects/deform/en/latest/basics.html#serving-up-the-rendered-form that the HTML should call deform.load() at will and suggest doing it at the end of the page.