Resolve change in InvalidNumber handling in writers #3390
+85
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3386 .
Summary/Motivation:
This resolves #3386 by making it so that both
InvalidNumber.__str__
andInvalidNumber.__repr__
raise exceptions. It was relatively straightforward to remove the use of string conversions in the tests so that we no longer needed to cast InvalidNumber to a string.Note that this includes an exception to the "str(InvalidNumber) raises an exception rule: if we are in the middle of processing an exception, this does not raise another exception and instead returns the old string representation.
Changes proposed in this PR:
InvalidNumber
so that bothstr()
andrepr()
raise exceptionsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: