Fix errors from zsa1 rebasing #831
ConstanceBeguierAnnotations
10 warnings
|
usage of `Iterator::fold` on a type that implements `Try`:
src/lib.rs#L886
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:886:10
|
886 | .fold(Some(ValueSum::zero()), |acc, action| {
| __________^
887 | | acc? + action.value_sum()
888 | | })
| |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
doc list item without indentation:
src/lib.rs#L53
warning: doc list item without indentation
--> src/bundle/commitments.rs:53:5
|
53 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
53 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L55
warning: doc list item without indentation
--> src/bundle/commitments.rs:55:5
|
55 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
55 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L57
warning: doc list item without indentation
--> src/bundle/commitments.rs:57:5
|
57 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
57 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L58
warning: doc list item without indentation
--> src/bundle/commitments.rs:58:5
|
58 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
58 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| +++
|
|
doc list item without indentation:
src/lib.rs#L113
warning: doc list item without indentation
--> src/bundle/commitments.rs:113:5
|
113 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
113 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L115
warning: doc list item without indentation
--> src/bundle/commitments.rs:115:5
|
115 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
115 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L117
warning: doc list item without indentation
--> src/bundle/commitments.rs:117:5
|
117 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
117 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
| +
|
|
doc list item without indentation:
src/lib.rs#L118
warning: doc list item without indentation
--> src/bundle/commitments.rs:118:5
|
118 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
118 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
| +++
|
|
first doc comment paragraph is too long:
src/lib.rs#L96
warning: first doc comment paragraph is too long
--> src/circuit.rs:96:1
|
96 | / /// The `OrchardCircuit` trait defines an interface for different implementations of the PLONK circuit
97 | | /// for the different Orchard protocol flavors (Vanilla and ZSA). It serves as a bridge between
98 | | /// plonk::Circuit interfaces and specific requirements of the Orchard protocol's variations.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
|