Fix PartialOrd impl for VerificationKey id redpallas, to fix incorrec… #526
Annotations
21 warnings
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:232:14
|
232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:226:14
|
226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/note_encryption_v3.rs#L343
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption_v3.rs:343:18
|
343 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
usage of `bool::then` in `filter_map`:
src/supply_info.rs#L67
warning: usage of `bool::then` in `filter_map`
--> src/supply_info.rs:67:18
|
67 | .filter_map(|(asset, supply)| supply.is_finalized.then(|| asset)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `filter` then `map` instead: `filter(|&(asset, supply)| supply.is_finalized).map(|(asset, supply)| asset)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_bool_then
= note: `#[warn(clippy::filter_map_bool_then)]` on by default
|
use of `default` to create a unit struct:
src/note/commitment.rs#L164
warning: use of `default` to create a unit struct
--> src/note/commitment.rs:164:31
|
164 | let mut os_rng = OsRng::default();
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
the borrowed expression implements the required traits:
tests/zsa.rs#L206
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:206:33
|
206 | proven.apply_signatures(&mut rng, sighash, &[]).unwrap()
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
the borrowed expression implements the required traits:
tests/zsa.rs#L98
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:98:27
|
98 | .apply_signatures(&mut rng, sighash, &[SpendAuthorizingKey::from(sk)])
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
the borrowed expression implements the required traits:
tests/zsa.rs#L85
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:85:17
|
85 | proven.sign(&mut rng, isk).unwrap()
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:232:14
|
232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:226:14
|
226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/note_encryption_v3.rs#L343
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption_v3.rs:343:18
|
343 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library/core/src/iter/traits/iterator.rs:642:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
usage of `bool::then` in `filter_map`:
src/supply_info.rs#L67
warning: usage of `bool::then` in `filter_map`
--> src/supply_info.rs:67:18
|
67 | .filter_map(|(asset, supply)| supply.is_finalized.then(|| asset)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `filter` then `map` instead: `filter(|&(asset, supply)| supply.is_finalized).map(|(asset, supply)| asset)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_bool_then
= note: `#[warn(clippy::filter_map_bool_then)]` on by default
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L530
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:530:14
|
530 | .fold(Some(ValueSum::zero()), |acc, action| {
| ______________^
531 | | acc? + action.value_sum()
532 | | })
| |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L455
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:455:14
|
455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L530
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:530:14
|
530 | .fold(Some(ValueSum::zero()), |acc, action| {
| ______________^
531 | | acc? + action.value_sum()
532 | | })
| |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L455
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:455:14
|
455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|