Skip to content

Enhance and cleanup ivk-to-bytes-visibility-downgrade branch (#81) #561

Enhance and cleanup ivk-to-bytes-visibility-downgrade branch (#81)

Enhance and cleanup ivk-to-bytes-visibility-downgrade branch (#81) #561

Triggered via push October 4, 2023 12:24
Status Success
Total duration 2m 20s
Artifacts

lints-beta.yml

on: push
Clippy (beta)
2m 6s
Clippy (beta)
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:232:14 | 232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:226:14 | 226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/note_encryption_v3.rs#L343
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption_v3.rs:343:18 | 343 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/b5c050febf10c9bcc0459d41fe2a1e190ad30b8d/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
use of `default` to create a unit struct: src/note/commitment.rs#L164
warning: use of `default` to create a unit struct --> src/note/commitment.rs:164:31 | 164 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:232:14 | 232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:226:14 | 226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/note_encryption_v3.rs#L343
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption_v3.rs:343:18 | 343 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/b5c050febf10c9bcc0459d41fe2a1e190ad30b8d/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L532
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:532:14 | 532 | .fold(Some(ValueSum::zero()), |acc, action| { | ______________^ 533 | | acc? + action.value_sum() 534 | | }) | |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L455
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:455:14 | 455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default
usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L532
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:532:14 | 532 | .fold(Some(ValueSum::zero()), |acc, action| { | ______________^ 533 | | acc? + action.value_sum() 534 | | }) | |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L455
warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:455:14 | 455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/