error[E0599]: no method named `extract_memo` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope --> src/note_encryption_v3.rs:489:48 | 179 | pub struct OrchardDomainV3 { | -------------------------- method `extract_memo` not found for this struct ... 489 | let (compact,parsed_memo) = domain.extract_memo(&plaintext); | ^^^^^^^^^^^^ method not found in `OrchardDomainV3` | ::: /home/runner/.cargo/git/checkouts/librustzcash-ab07dea6eb75be51/d55ef03/components/zcash_note_encryption/src/lib.rs:243:8 | 243 | fn extract_memo( | ------------ the method is available for `note_encryption_v3::OrchardDomainV3` here | = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 450 + use zcash_note_encryption::Domain; |

no function or associated item named `note_plaintext_bytes` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope: src/note_encryption_v3.rs#L484

error[E0599]: no function or associated item named `note_plaintext_bytes` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope --> src/note_encryption_v3.rs:484:50 | 179 | pub struct OrchardDomainV3 { | -------------------------- function or associated item `note_plaintext_bytes` not found for this struct ... 484 | let mut plaintext = OrchardDomainV3::note_plaintext_bytes(&note, memo); | ^^^^^^^^^^^^^^^^^^^^ function or associated item not found in `OrchardDomainV3` | = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 450 + use zcash_note_encryption::Domain; |

unresolved import `zcash_note_encryption`: src/note_encryption_v3.rs#L452

error[E0432]: unresolved import `zcash_note_encryption` --> src/note_encryption_v3.rs:452:9 | 452 | use zcash_note_encryption::{ | ^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `zcash_note_encryption` | help: there is a crate or module with a similar name | 452 | use zcash_note_encryption_zsa::{ | ~~~~~~~~~~~~~~~~~~~~~~~~~

Test on ubuntu-latest: src/note_encryption_v3.rs#L452

unresolved import `zcash_note_encryption`

Test on ubuntu-latest: src/note_encryption_v3.rs#L484

no function or associated item named `note_plaintext_bytes` found for struct `OrchardDomainV3` in the current scope

Test on ubuntu-latest: src/note_encryption_v3.rs#L489

no method named `extract_memo` found for struct `OrchardDomainV3` in the current scope

Test on ubuntu-latest

could not compile `orchard` due to 3 previous errors

Test on ubuntu-latest

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Test on macOS-latest

The operation was canceled.

Bitrot check: benches/note_decryption.rs#L13

unresolved import `zcash_note_encryption`

Bitrot check

could not compile `orchard` due to previous error

Bitrot check

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Test on windows-latest

The operation was canceled.

Intra-doc links: src/builder.rs#L340

unresolved link to `zcash_note_encryption`

Intra-doc links

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

no method named `extract_memo` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope: src/note_encryption_v3.rs#L489

error[E0599]: no method named `extract_memo` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope --> src/note_encryption_v3.rs:489:48 | 179 | pub struct OrchardDomainV3 { | -------------------------- method `extract_memo` not found for this struct ... 489 | let (compact,parsed_memo) = domain.extract_memo(&plaintext); | ^^^^^^^^^^^^ method not found in `note_encryption_v3::OrchardDomainV3` | ::: /home/runner/.cargo/git/checkouts/librustzcash-ab07dea6eb75be51/d55ef03/components/zcash_note_encryption/src/lib.rs:243:8 | 243 | fn extract_memo( | ------------ the method is available for `note_encryption_v3::OrchardDomainV3` here | = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 450 | use zcash_note_encryption::Domain; |

no function or associated item named `note_plaintext_bytes` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope: src/note_encryption_v3.rs#L484

error[E0599]: no function or associated item named `note_plaintext_bytes` found for struct `note_encryption_v3::OrchardDomainV3` in the current scope --> src/note_encryption_v3.rs:484:50 | 179 | pub struct OrchardDomainV3 { | -------------------------- function or associated item `note_plaintext_bytes` not found for this struct ... 484 | let mut plaintext = OrchardDomainV3::note_plaintext_bytes(&note, memo); | ^^^^^^^^^^^^^^^^^^^^ function or associated item not found in `note_encryption_v3::OrchardDomainV3` | = help: items from traits can only be used if the trait is in scope help: the following trait is implemented but not in scope; perhaps add a `use` for it: | 450 | use zcash_note_encryption::Domain; |

mismatched types: src/circuit.rs#L430

error[E0308]: mismatched types --> src/circuit.rs:430:17 | 425 | let sinsemilla_config_2 = SinsemillaChip::configure( | ------------------------- arguments to this function are incorrect ... 430 | lookup, | ^^^^^^ expected a tuple with 4 elements, found one with 3 elements | = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12 | 151 | pub fn configure( | ^^^^^^^^^

mismatched types: src/circuit.rs#L412

error[E0308]: mismatched types --> src/circuit.rs:412:17 | 407 | let sinsemilla_config_1 = SinsemillaChip::configure( | ------------------------- arguments to this function are incorrect ... 412 | lookup, | ^^^^^^ expected a tuple with 4 elements, found one with 3 elements | = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12 | 151 | pub fn configure( | ^^^^^^^^^

this function takes 4 arguments but 3 arguments were supplied: src/circuit.rs#L384

error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> src/circuit.rs:384:27 | 384 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing | note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12 | 83 | pub fn configure( | ^^^^^^^^^ help: provide the argument | 384 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

mismatched types: src/circuit/value_commit_orchard.rs#L197

error[E0308]: mismatched types --> src/circuit/value_commit_orchard.rs:197:21 | 192 | let sinsemilla_config = SinsemillaChip::configure( | ------------------------- arguments to this function are incorrect ... 197 | lookup, | ^^^^^^ expected a tuple with 4 elements, found one with 3 elements | = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12 | 151 | pub fn configure( | ^^^^^^^^^

this function takes 4 arguments but 3 arguments were supplied: src/circuit/value_commit_orchard.rs#L190

error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> src/circuit/value_commit_orchard.rs:190:35 | 190 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing | note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12 | 83 | pub fn configure( | ^^^^^^^^^ help: provide the argument | 190 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

mismatched types: src/circuit/note_commit.rs#L2398

error[E0308]: mismatched types --> src/circuit/note_commit.rs:2398:21 | 2389 | let sinsemilla_config = SinsemillaChip::< | _________________________________________- 2390 | | OrchardHashDomains, 2391 | | OrchardCommitDomains, 2392 | | OrchardFixedBases, 2393 | | >::configure( | |____________________________- arguments to this function are incorrect ... 2398 | lookup, | ^^^^^^ expected a tuple with 4 elements, found one with 3 elements | = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12 | 151 | pub fn configure( | ^^^^^^^^^

this function takes 4 arguments but 3 arguments were supplied: src/circuit/note_commit.rs#L2388

error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> src/circuit/note_commit.rs:2388:35 | 2388 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing | note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12 | 83 | pub fn configure( | ^^^^^^^^^ help: provide the argument | 2388 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

this function takes 4 arguments but 3 arguments were supplied: src/circuit/gadget/mux_chip.rs#L231

error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> src/circuit/gadget/mux_chip.rs:231:35 | 231 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing | note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12 | 83 | pub fn configure( | ^^^^^^^^^ help: provide the argument | 231 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

mismatched types: src/circuit/commit_ivk.rs#L763

error[E0308]: mismatched types --> src/circuit/commit_ivk.rs:763:21 | 754 | let sinsemilla_config = SinsemillaChip::< | _________________________________________- 755 | | OrchardHashDomains, 756 | | OrchardCommitDomains, 757 | | OrchardFixedBases, 758 | | >::configure( | |____________________________- arguments to this function are incorrect ... 763 | lookup, | ^^^^^^ expected a tuple with 4 elements, found one with 3 elements | = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)` note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12 | 151 | pub fn configure( | ^^^^^^^^^

this function takes 4 arguments but 3 arguments were supplied: src/circuit/commit_ivk.rs#L753

error[E0061]: this function takes 4 arguments but 3 arguments were supplied --> src/circuit/commit_ivk.rs:753:35 | 753 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing | note: associated function defined here --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12 | 83 | pub fn configure( | ^^^^^^^^^ help: provide the argument | 753 | let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

mismatched types: src/circuit.rs#L430

mismatched types: src/circuit.rs#L412

this function takes 4 arguments but 3 arguments were supplied: src/circuit.rs#L384

unresolved import `zcash_note_encryption`: src/note_encryption_v3.rs#L452

Book tests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Book tests

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Book tests

Rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rustfmt

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L232

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:232:14 | 232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

usage of `Iterator::fold` on a type that implements `Try`: src/value.rs#L226

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/value.rs:226:14 | 226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/note_encryption_v3.rs#L343

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/note_encryption_v3.rs:343:18 | 343 | .zip(ephemeral_keys.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/b5c050febf10c9bcc0459d41fe2a1e190ad30b8d/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L532

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:532:14 | 532 | .fold(Some(ValueSum::zero()), |acc, action| { | ______________^ 533 | | acc? + action.value_sum() 534 | | }) | |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

usage of `Iterator::fold` on a type that implements `Try`: src/builder.rs#L455

warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:455:14 | 455 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

Test on ubuntu-latest