Skip to content

Commit

Permalink
Removed extra FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
dmidem committed Jul 15, 2024
1 parent de85554 commit b20ff2f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions benches/note_decryption.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ fn bench_note_decryption<FL: OrchardFlavorBench>(c: &mut Criterion) {
let recipient = valid_ivk.address_at(0u32);
let valid_ivk = PreparedIncomingViewingKey::new(&valid_ivk);

// FIXME: should we add to the following comment that now for ZSA flavor the early
// rejection also happens when the asset is invalid?
// Compact actions don't have the full AEAD ciphertext, so ZIP 307 trial-decryption
// relies on an invalid ivk resulting in random noise for which the note commitment
// is invalid. However, in practice we still get early rejection:
Expand Down
2 changes: 0 additions & 2 deletions src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,6 @@ impl Builder {
}

/// Add an instruction to burn a given amount of a specific asset.
// FIXME: Should we add `add_burn` into the `into_bundle` function in this testing module
// (like `add_spend` and `add_output` are used there)?
pub fn add_burn(&mut self, asset: AssetBase, value: NoteValue) -> Result<(), BuildError> {
use std::collections::hash_map::Entry;

Expand Down

0 comments on commit b20ff2f

Please sign in to comment.