Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for Orchard/ZSA backward compatability in Librustzcash #107

Conversation

alexeykoren
Copy link

No description provided.

Copy link

what-the-diff bot commented Jun 3, 2024

PR Summary

  • Enhanced Error Handling
    The BuildError enum in the builder.rs file has been expanded to include two new variants (BurnErrorNative and BurnErrorZero), providing a more comprehensive and specific breakdown of possible errors. This is further supported by the implementation of the Display trait, augmenting readability and understandability of the error message.

  • Improved Function Updates
    The add_burn function, part of the Builder struct in the builder.rs, now has an improved return type. It provides a Result with the expanded BuildError as the error type, replacing the previously used &'static str. Additionally, a new method map_proof has been incorporated into InProgress struct, also found in builder.rs.

  • Module Renaming and Addition
    The domain module in note_encryption.rs has been renamed to pub mod domain for better visibility and naming consistency. Additionally, a new file domain.rs has been added to the note_encryption directory.

  • Enhanced Struct and Function
    A new method from_data has been added to the Signed struct residing in issuance.rs. Furthermore, the build_and_verify_bundle function in zsa.rs has been updated to handle the new returns from the add_burn function.

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice
@dmidem should merge when ready

@dmidem dmidem merged commit e10efb3 into orchardzsa-backward-compatability-0.8.0 Jun 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants