forked from zcash/orchard
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZSA assets swap #116
Open
ConstanceBeguier
wants to merge
19
commits into
zsa1
Choose a base branch
from
zsa_swap
base: zsa1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ZSA assets swap #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstanceBeguier
force-pushed
the
zsa_swap
branch
from
October 10, 2024 15:51
9e0b5bf
to
0f00238
Compare
ConstanceBeguier
force-pushed
the
zsa_swap
branch
from
October 15, 2024 10:58
b9e9112
to
f4fdf5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to create
ActionGroup
andSwapBundle
for performing asset swaps.This PR modifies the
Builder
:build_action_group
function allows the creation of anActionGroup
from aBuilder
. Like when creating aBundle
, theActionGroup
will initially be without proof and signatures. You will need to callcreate_proof
andapply_signatures
to add them.This PR creates a new
SwapBundle
structure. ASwapBundle
is created from a list ofActionGroups
. During this creation, the following operations are performedSwapBundle
(by summing the value balances of eachActionGroup
).bsk
of theSwapBundle
(by summing thebsk
of eachActionGroup
).SwapBundle
which is equal to the signature of the SwapBundle SIGHASH with the binding signature keybsk
.