Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating variable name from sk_iss and idk to imk #84

Closed
wants to merge 1 commit into from

Conversation

vivek-arte
Copy link

This PR updates the notation for the issuance keys in order to make it consistent with the spec.

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023

PR Summary

This Pull Request (PR) involves a significant update of the terminology used in several files of the codebase. The term sk_iss has been replaced with imk throughout these files, which helps to increase code clarity and consistency. Here are the key changes:

  • Refactoring in issuance.rs file

    • The term sk_iss has been updated to imk on lines 626 and 1276 for better variable representation.
  • Updates in keys.rs file

    • Renamed sk_iss to imk on lines 259, 314 and 1269 improving the readability and understanding of the code.
  • Renaming in note/asset_base.rs file

    • The term sk_iss has been replaced with imk on lines 104 and 169 enhancing consistency across codebase.
  • Changes in supply_info.rs file

    • Line 84 saw the replacement of sk_iss with imk which offers better variable naming conventions.
  • Adjustments in tests/zsa.rs file

    • The occurrence of sk_iss on line 63 is now changed to imk, streamlining code terminology.

These changes do not modify the functionality of the code, but they significantly improve the readability and consistency of the codebase. This makes future development and maintenance easier.

@vivek-arte
Copy link
Author

Closed in favour of #92

@vivek-arte vivek-arte closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant