Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IssuanceKey struct to IssuanceMasterKey #91

Closed
wants to merge 1 commit into from

Conversation

vivek-arte
Copy link

This PR makes a consistent rename of the struct in order to improve consistency with ZIP 227.

@what-the-diff
Copy link

what-the-diff bot commented Oct 17, 2023

PR Summary

This update has one main change discussed as follows:

  • Updating Key Type from IssuanceKey to IssuanceMasterKey

The PR introduces a term change from IssuanceKey to IssuanceMasterKey. This update can be found throughout several files. The new term IssuanceMasterKey appears clearer and more descriptive, potentially leading to better user understanding when navigating through the code.

The files affected by this change include:

  • burn_validation.rs: This term was changed in a function get_burn_tuple.
  • issuance.rs: The change was implemented multiple times in this file.
  • keys.rs: The old term was completely replaced with the new term.
  • note/asset_base.rs: The term was changed in a function random.
  • supply_info.rs: This term was modified in a function create_test_asset.
  • zsa.rs: This term was changed in a function prepare_keys.

The change enhances readability, making the code easier to follow and understand.

@vivek-arte vivek-arte force-pushed the idk_to_imk branch 2 times, most recently from bf1ea63 to 6ed9455 Compare October 25, 2023 11:33
@vivek-arte
Copy link
Author

Closed in favour of #92

@vivek-arte vivek-arte closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant