Skip to content

Porting Batch Validator changes on top of the latest version of zsa1 … #566

Porting Batch Validator changes on top of the latest version of zsa1 …

Porting Batch Validator changes on top of the latest version of zsa1 … #566

GitHub Actions / Clippy (1.65.0) failed Oct 16, 2023 in 0s

Clippy (1.65.0)

13 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 13
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 430 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit.rs:430:17
    |
425 |             let sinsemilla_config_2 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
430 |                 lookup,
    |                 ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 412 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit.rs:412:17
    |
407 |             let sinsemilla_config_1 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
412 |                 lookup,
    |                 ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 384 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> src/circuit.rs:384:27
    |
384 |         let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
    |
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
    |
83  |     pub fn configure(
    |            ^^^^^^^^^
help: provide the argument
    |
384 |         let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
    |                                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 197 in src/circuit/value_commit_orchard.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit/value_commit_orchard.rs:197:21
    |
192 |                 let sinsemilla_config = SinsemillaChip::configure(
    |                                         ------------------------- arguments to this function are incorrect
...
197 |                     lookup,
    |                     ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 190 in src/circuit/value_commit_orchard.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> src/circuit/value_commit_orchard.rs:190:35
    |
190 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
    |
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
    |
83  |     pub fn configure(
    |            ^^^^^^^^^
help: provide the argument
    |
190 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
    |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 2398 in src/circuit/note_commit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
    --> src/circuit/note_commit.rs:2398:21
     |
2389 |                   let sinsemilla_config = SinsemillaChip::<
     |  _________________________________________-
2390 | |                     OrchardHashDomains,
2391 | |                     OrchardCommitDomains,
2392 | |                     OrchardFixedBases,
2393 | |                 >::configure(
     | |____________________________- arguments to this function are incorrect
...
2398 |                       lookup,
     |                       ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
     |
     = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
                found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
    --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
     |
151  |     pub fn configure(
     |            ^^^^^^^^^

Check failure on line 2388 in src/circuit/note_commit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
    --> src/circuit/note_commit.rs:2388:35
     |
2388 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
     |
note: associated function defined here
    --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
     |
83   |     pub fn configure(
     |            ^^^^^^^^^
help: provide the argument
     |
2388 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
     |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 231 in src/circuit/gadget/mux_chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> src/circuit/gadget/mux_chip.rs:231:35
    |
231 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
    |
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
    |
83  |     pub fn configure(
    |            ^^^^^^^^^
help: provide the argument
    |
231 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
    |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 763 in src/circuit/commit_ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit/commit_ivk.rs:763:21
    |
754 |                   let sinsemilla_config = SinsemillaChip::<
    |  _________________________________________-
755 | |                     OrchardHashDomains,
756 | |                     OrchardCommitDomains,
757 | |                     OrchardFixedBases,
758 | |                 >::configure(
    | |____________________________- arguments to this function are incorrect
...
763 |                       lookup,
    |                       ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 430 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit.rs:430:17
    |
425 |             let sinsemilla_config_2 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
430 |                 lookup,
    |                 ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 753 in src/circuit/commit_ivk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> src/circuit/commit_ivk.rs:753:35
    |
753 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
    |
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
    |
83  |     pub fn configure(
    |            ^^^^^^^^^
help: provide the argument
    |
753 |                 let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
    |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 412 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

mismatched types

error[E0308]: mismatched types
   --> src/circuit.rs:412:17
    |
407 |             let sinsemilla_config_1 = SinsemillaChip::configure(
    |                                       ------------------------- arguments to this function are incorrect
...
412 |                 lookup,
    |                 ^^^^^^ expected a tuple with 4 elements, found one with 3 elements
    |
    = note: expected tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
               found tuple `(halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn, halo2_proofs::plonk::TableColumn)`
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/sinsemilla/chip.rs:151:12
    |
151 |     pub fn configure(
    |            ^^^^^^^^^

Check failure on line 384 in src/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.65.0)

this function takes 4 arguments but 3 arguments were supplied

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> src/circuit.rs:384:27
    |
384 |         let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx);
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- an argument of type `halo2_proofs::plonk::TableColumn` is missing
    |
note: associated function defined here
   --> /home/runner/.cargo/git/checkouts/halo2-3f0a27d7d67144fe/28af760/halo2_gadgets/src/utilities/lookup_range_check.rs:83:12
    |
83  |     pub fn configure(
    |            ^^^^^^^^^
help: provide the argument
    |
384 |         let range_check = LookupRangeCheckConfig::configure(meta, advices[9], table_idx, /* halo2_proofs::plonk::TableColumn */);
    |                                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~