Skip to content

When building a SwapBundle, remove bsk for each action group #1517

When building a SwapBundle, remove bsk for each action group

When building a SwapBundle, remove bsk for each action group #1517

GitHub Actions / Clippy Result (stable) succeeded Oct 17, 2024 in 18s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~18466ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 54 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L54

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:54:5
   |
54 | ///   with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
54 | ///    with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 56 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L56

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:56:5
   |
56 | ///   with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
56 | ///    with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |       +

Check warning on line 58 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L58

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:58:5
   |
58 | ///   with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
58 | ///    with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 59 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L59

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:59:5
   |
59 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
59 | ///    as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     +++

Check warning on line 218 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L218

the following explicit lifetimes could be elided: 'a
Raw output
warning: the following explicit lifetimes could be elided: 'a
   --> src/bundle.rs:218:14
    |
218 |         impl<'a, A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'a, A, D> {
    |              ^^                                                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
218 -         impl<'a, A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'a, A, D> {
218 +         impl<A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'_, A, D> {
    |

Check warning on line 270 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L270

use of a fallible conversion when an infallible one could be used
Raw output
warning: use of a fallible conversion when an infallible one could be used
   --> src/keys.rs:270:27
    |
270 |         self.0.to_bytes().try_into().unwrap()
    |                           ^^^^^^^^^^^^^^^^^^^
    |
    = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
    |
270 -         self.0.to_bytes().try_into().unwrap()
270 +         self.0.to_bytes().into()
    |

Check warning on line 337 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L337

use of a fallible conversion when an infallible one could be used
Raw output
warning: use of a fallible conversion when an infallible one could be used
   --> src/keys.rs:337:27
    |
337 |         self.0.to_bytes().try_into().unwrap()
    |                           ^^^^^^^^^^^^^^^^^^^
    |
    = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
help: use
    |
337 -         self.0.to_bytes().try_into().unwrap()
337 +         self.0.to_bytes().into()
    |

Check warning on line 114 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L114

unused return value of `std::hash::Hasher::finish` that must be used
Raw output
warning: unused return value of `std::hash::Hasher::finish` that must be used
   --> src/note/asset_base.rs:114:9
    |
114 |         h.finish();
    |         ^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
114 |         let _ = h.finish();
    |         +++++++