(cherry picked from commit bitcoin/bitcoin@2022917)

-BEGIN VERIFY SCRIPT-
sed -i 's/privkey/seckey/g' src/key.cpp
-END VERIFY SCRIPT-

(cherry picked from commit bitcoin/bitcoin@e10439c)

Zcashd release candidate v5.5.0-rc1

This enables PRs that have release notes to be merged in parallel to the
RC process.

Merge v5.5.0-rc1 into the main branch

This allows zcash_script to include!() the file as part of its build process.

…from_Makefile

Add reference in Makefile.am to zip317.h

(needed to test the help change in the next commit).

Signed-off-by: Daira Emma Hopwood <[email protected]>

… fee,

size, logical action count, and unpaid action count. This reflects the
changes to use the ZIP 317 block construction algorithm and de-emphasise
fee rate.

Signed-off-by: Daira Emma Hopwood <[email protected]>

Change module comment in bridge.rs to doc comment to fix errors in zcash_script build

Previously, there were no arguments after `memo`, so it could always just be
omitted. Now the `privacyPolicy` is there, so it’s necessary to be able to
explicitly omit the memo.

Using `"F6"` would work in some situations, but while it encodes the “no memo”
case, the internal checks that ensure we don’t try to send a memo to transparent
recipients fail on it. And as we can’t merge to a taddr without specifying
`"AllowRevealedRecipients"`, this prevents merging to taddrs (unless the
deprecated `legacy_privacy` feature is enabled).

This change makes it possible to send `null` as the `memo` argument, which
indicates “no memo” successfully. It does the same for `*_limit` parameters in
`z_mergetoaddress` and `z_shieldcoinbase` (even though those don’t have a
similar failure case), since those parameters also need to be specified when the
`privacyPolicy` is, and it’s consistent with zcash#6599, rather than hardcoding some
particular value.

This also fixes a bug in `WalletTxBuilder` that could inadvertently require
`AllowRevealedAmounts` on a transaction from a shielded pool to itself (via
`NetAmountRecipient`).

Allow explicit “no memo” in z_mergetoaddress

Add `memo` parameter to `z_shieldcoinbase`

This also removes the restriction on merging Sprout to Sapling, as that is now controlled by
`privacyPolicy`.

UA and cross-pool support in `z_mergetoaddress`, plus fixing a typo.

Improve `-printpriority` output to log the modified fee, conventional fee, size, logical actions, and unpaid actions

Co-authored-by: Daira Hopwood <[email protected]>

Co-authored-by: Daira Hopwood <[email protected]>

Support UA destinations in `z_mergetoaddress`

Signed-off-by: Daira Emma Hopwood <[email protected]>

are selected.

Signed-off-by: Daira Emma Hopwood <[email protected]>

This ensures that if a rebuild of `rustcxx` is triggered but not a
rebuild of `native_cxxbridge` (as can happen when a native toolchain
package is updated), the source used by `rustcxx` is not missing.

Currently the linker silently fails, which breaks the build process.
These utilities are not necessary for the overall build, and macOS is
currently a Tier 3 platform, so we can skip building them for now.

We already weren't including their corresponding binaries. This change
reduces the size of the `native_clang` cache tarball by 69 MB.

This ensures that we catch regressions in any of these individually. We
always run these checks if the default build succeeds, in order to gain
more information if any one of them fails.

…ression

Fix `--disable-mining` build regression

CI: Add a GitHub Actions workflow that builds zcashd for platform tiers

Also fixes the halt height for v5.5.0-rc1.

Co-authored-by: Daira Emma Hopwood <[email protected]>

We were previously getting this header via BDB. We don't need it on
native Windows because it gets provided via `windows.h`, but MinGW has
their own `windows.h` that doesn't do so.

This allows zcash_script to include!() the file as part of its build process.

Release v5.5.0-rc2

Merge v5.5.0-rc2 back to `master`.

Signed-off-by: Daira Emma Hopwood <[email protected]>

Also remove DEFAULT_FEE_ZATS in RPC tests which was unused.

Signed-off-by: Daira Emma Hopwood <[email protected]>

This affects both `z_mergetoaddress` and `z_shieldcoinbase`, but `z_mergetoaddress` is the important
case, where currently you can’t merge to a taddr without specifying a `privacyPolicy`.

This is the value that represents the empty memo, but it currently has two
representations internally. Previously, passing a literal "F6" to an RPC call
would create the `std::optional(Memo({{0xf6}}))` representation, but this change
makes it use the `std::nullopt` representation, which is harder to avoid
checking. And it fixes a bug where you couldn’t provide any value to `zcash-cli`
that would result in the `std::nullopt` representation.

Fix issues in zcash-cli

Previously, command-line arguments would be treated as either a verbatim string
or parsed to a JSON value. This adds a third case, where we first check if the
argument is JSON `null`. If so, we treat it as null, otherwise we pass the
original string.

Support nullable strings in `zcash-cli`

This is mostly prep for memo encapsulation. The constants have been relocated,
changed from `#define` to `constexpr`, moved into a namespace, and lost their
`ZC_` prefix (redundant with the new namespacing).

`ZC_DIVERSIFIER_SIZE` has also been renamed to `SAPLING_DIVERSIFIER_SIZE`.

There’s a `Memo` class that was introduced with the WalletTxBuilder work, but it
was restricted to the wallet. This moves it to libzcash, uses it universally,
and makes it a lot more robust.

The only place (outside of tests) that uses `Memo::Bytes` is
`BaseNotePlaintext`, which needs a particular in-memory representation. But the
API for `*NotePlaintext` is in terms of the `Memo` class.

`z_viewtransaction` includes a `memoStr` field whenever the memo contains valid
UTF-8 data. This change does the same for other `memo`-returning methods –
currently `z_listreceivedbyaddress`, `z_listunspent`, and
`z_validatepaymentdisclosure`.

Signed-off-by: Daira Emma Hopwood <[email protected]>

Release v5.5.0 rc3

Remove fee estimation and `estimatefee` RPC method

Fix a false positive duplicate-#include lint

Co-authored-by: Kris Nuttycombe <[email protected]>

Co-authored-by: Daira Hopwood <[email protected]>

Co-authored-by: Daira Hopwood <[email protected]>

Remove "$ zcash-cli" from output and print the RPC call name and
arguments, since `zcash-cli` is not actually used to invoke the RPC
methods and in some cases, what's printed out is not usable as-is to run
via `zcash-cli`.

When everything passes, still show “True”, but when there are failures, show passed/total.

Update `smoke_tests.py` to run against 5.5.0, using `allowdeprecated`

Release v5.5.0

Version 5.5.0 merge

…exGuts

…checks

txdb: remove consistency checks

Follow-up to zcash#6617.

Signed-off-by: Daira Emma Hopwood <[email protected]>

This also adds a generic `FormatList` function that will print any Container human-readably.

Not sure if it’s because of Clang 13 or something else, but the macOS build
seems more sensitive to some missing includes.

Fix macOS build on CI

Centralize ReceiverType conversions

Encapsulate memos

Display pass ratio in RPC test summary

This check ensured that PR branches were based on a recent-enough master to work
with current Tekton builds. This check is now performed on the Tekton side
(Electric-Coin-Company/infrastructure#1613), where it more correctly belongs (as
this is effectively tracking Tekton’s dependency on zcash/zcash).

Remove GitHub check for recent-enough branch

This is presumably a transitive `include` discrepancy. I.e., there is some other `std` header that
has `#include <variant>` etc. in Clang 15 (our usual compiler) but doesn’t have it in Clang 13 (our
macOS compiler).

Avoid calling `ParseNonRFCJSONValue` for string-only parameters

Fix missing includes on macOS build

This has a rather complicated set of flags that should be simplified over time.