COMP: Update python executable location and usage #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the CMake Python3 module instead of PythonInterp, which it has
replaced with the Interpreter COMPONENT.
Use Python 3 instead of Python 2, which is end-of-life.
Ensure we use ${Python3_EXECUTABLE} in the test commands.
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Dec 10, 2024
Through upstream patch: QIICR/dcmqi#511
CPython 3.8 is officially end-of-life by upstream.
|
|
Makes sense, thank you @thewtex! 👍 |
|
Should I make a new dcmqi release? |
|
@fedorov thanks for the review and merge! I will just use the Git hash, so a new release is not required for my needs. |
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Dec 10, 2024
Through upstream patch: QIICR/dcmqi#511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the CMake Python3 module instead of PythonInterp, which it has
replaced with the Interpreter COMPONENT.
Use Python 3 instead of Python 2, which is end-of-life.
Ensure we use ${Python3_EXECUTABLE} in the test commands.