Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TEM documentation #2088

Merged
merged 13 commits into from
Oct 15, 2024

Conversation

ludmilaasb
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@pandasa123 pandasa123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ludmilaasb, thank you and the team for these updates. I've added a few minor requests

docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@pandasa123 pandasa123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see max_execution_time! This looks great. Minor feedback below for a single point

docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny tweaks in one sentence - looks good to me otherwise, but @pandasa123 should give the final approval. Thanks!

docs/guides/algorithmiq-tem.ipynb Outdated Show resolved Hide resolved
"metadata": {},
"outputs": [],
"source": [
"import logging\n",
"result = job.result()"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code example should show how to extract the expectation value, e.g. result[0].data.evs. It can be this one, or the one in output, or both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I added the suggested snippet to the notebook cell

"source": [
"## Inputs\n",
"\n",
"**Parameters**\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bothers me slightly that the parameters are not all in the same order across functions, even though they are all the same. But it's not a huge deal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the order to the following:

  • pubs
  • backend_name
  • instance
  • options

docs/guides/algorithmiq-tem.ipynb Show resolved Hide resolved
@abbycross abbycross added this pull request to the merge queue Oct 15, 2024
Merged via the queue into Qiskit:main with commit 991d37a Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants