-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TEM documentation #2088
Update TEM documentation #2088
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ludmilaasb, thank you and the team for these updates. I've added a few minor requests
Co-authored-by: abbycross <[email protected]>
Co-authored-by: abbycross <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to see max_execution_time
! This looks great. Minor feedback below for a single point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tweaks in one sentence - looks good to me otherwise, but @pandasa123 should give the final approval. Thanks!
Co-authored-by: abbycross <[email protected]>
docs/guides/algorithmiq-tem.ipynb
Outdated
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"import logging\n", | ||
"result = job.result()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One code example should show how to extract the expectation value, e.g. result[0].data.evs
. It can be this one, or the one in output, or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, I added the suggested snippet to the notebook cell
"source": [ | ||
"## Inputs\n", | ||
"\n", | ||
"**Parameters**\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It bothers me slightly that the parameters are not all in the same order across functions, even though they are all the same. But it's not a huge deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the order to the following:
- pubs
- backend_name
- instance
- options
No description provided.