Fix external link checker exception handling #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Oct 17, 2024
| @@ -20,21 +20,38 @@ test("ExternalLink constructor ignores anchors", () => { | |||
| }); | |||
|
|
|||
| test.describe("ExternalLink.check()", () => { | |||
| let originalFetch: typeof global.fetch; | |||
There was a problem hiding this comment.
Note that this approach would not be safe if Playwright ran the tests inside a file in parallel. However, it runs them sequentially.
frankharkins
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't properly catching errors due to reusing the symbol
error. That resulted in a test recently saying that a link we expected to 404 was instead a valid link.This PR also improves the tests to be deterministic by mocking
fetch(). This removes the risk of flakiness and makes our test faster.