fix : #510, Removed package_to_check variable and updated references #511
Conversation
…ences Signed-off-by: Shobhit Kumar <[email protected]>
|
|
…957/ecosystem into remove-package-to-check
|
Do not hesitate to ping me when it's ok for you :) |
|
Hey, what should I do, how can this can be merged?, I'm a beginner to this open-source community...please help me.. |
For merging we'll do it for you :) just continue to commit and you think your PR is ready just ping me I'll review it and then I'll ping someone who can merge it. Here you cleaned the tox tpl, you can as well delete wherever this var is called in the code. |
|
So, should I do that too?, like should I delete the var where ever it is in the code? |
Yes :) |
…ced it with qiskit Signed-off-by: Shobhit Kumar <[email protected]>
|
Oops!, Very Sorry..my bad, I'll do that again.. |
Signed-off-by: Shobhit Kumar <[email protected]>
Signed-off-by: Shobhit Kumar <[email protected]>
Signed-off-by: Shobhit Kumar <[email protected]>
ecosystem/manager.py
Outdated
| <<<<<<< HEAD | ||
| ======= | ||
| qiskit: str, | ||
| >>>>>>> 2b284cffea465cb413ac35b655efce9f5be03546 |
There was a problem hiding this comment.
Hey, it looks like you have a lot of merge conflicts still like this, if you look through the "Files changed" tab on GitHub.
Thanks for your contribution by the way! We appreciate your help.
There was a problem hiding this comment.
Hey, sorry for this..actually i'm a beginner here..learning and applying things. So I made this mistake, so sorry for that...will push the pr again in couple of minutes...Thanks for providing me this opportunity bro.
Signed-off-by: Shobhit Kumar <[email protected]>
|
Hey bro.. You can check, if I again made any mistake, please tell me bro.. I'll solve it and push the commit again... |
There was a problem hiding this comment.
This looks good to me! I'll wait for @mickahell to review.
please tell me bro
Gentle tip: it's better to not use "bro" when interacting with people in developer spaces like GitHub and open source. It's really casual, whereas we try to be a little more professional with GitHub.
Also not everyone identifies as male, and it's not safe to assume how someone identifies. For example, I'm non-binary so "bro" doesn't describe me.
|
Yep!, I'll follow the tip. |
There was a problem hiding this comment.
Yeah seems good to me too :)
@Eric-Arellano could you merge it please 🚀
Fix: #510
Removed package_to_check variable and updated according to the reference.