Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename moved members + adapt packages setup for requirements project #512

Merged
merged 27 commits into from
Aug 30, 2023

Conversation

mickahell
Copy link
Collaborator

@mickahell mickahell commented Aug 27, 2023

Summary

Some members changed their name or moved their repo.
I'm correcting then with the good new name.

Details and comments

  • Change url of qiskit-superstaq
  • Change url of pytket-qiskit
  • Adapt packages installation for projects with no requirements.txt
  • Update tests

Closes #502
Closes #202

mickahell and others added 24 commits July 27, 2023 18:44
* force string for output

* Revert "force string for output"

This reverts commit cabecb9.

* make stable and dev check informational + badge good when only standard

* set messages

* update unit tests

* lint

* lint

* fork doesn't sync

* fork sync

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

Co-authored-by: Frank Harkins <[email protected]>

* add assert for set_actions_output
Co-authored-by: Frank Harkins <[email protected]>

* Revert "add assert for set_actions_output"

This reverts commit 51c0f56.

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

* no regex in actions if

* clear condition

---------

Co-authored-by: Frank Harkins <[email protected]>
Badges and stars update
Time: 2023_08_02_13_46

Co-authored-by: frankharkins <[email protected]>
@mickahell mickahell marked this pull request as draft August 27, 2023 16:21
@mickahell mickahell changed the title Rename moved members Rename moved members + adapt packages setup for requirements project Aug 27, 2023
@mickahell mickahell added the bug Something isn't working label Aug 27, 2023
@mickahell mickahell marked this pull request as ready for review August 27, 2023 17:26
@mickahell
Copy link
Collaborator Author

Ready for your review @frankharkins :)

Adapting for project who doesn't have a requirements.txt file, I thing I did the most simple we could without impacting actual members and without complicate our code. Also I think that the most respect what a most valid project structure is from our point of view.
Checking if the file exist before templating the command would add new variables between functions and so would complicate our actual code I think.

@mickahell mickahell self-assigned this Aug 27, 2023
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frankharkins frankharkins merged commit 1f33f16 into Qiskit:main Aug 30, 2023
4 checks passed
@mickahell mickahell deleted the bug/renamed-repo branch August 31, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some check_project actions are failing pytket-extensions installation workflow fails
2 participants