Adding from_designator + notes for usage #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
In CI this often fails even if it succeeds locally. * Limit the version of triomphe to 0.1.11 because 0.1.12 uses unstable features * Remove some conditional compilation for clippy complaints. Maybe clippy was upgraded independently of rustc?
* Factor lowering a list of qubits into a helper function fixes: Qiskit#163 * Update crates/oq3_semantics/src/syntax_to_semantics.rs remove comments that were moved elsewhere * Update crates/oq3_semantics/src/syntax_to_semantics.rs Move a comment from elsewhere to here, where it makes more sense. * Run cargo fmt --------- Co-authored-by: John Lapeyre <[email protected]>
|
This PR has a merge conflict. probably because main was updated. I think the updated main branch will fix the CI failure above. |
Just rebased my fork, ideally should have fixed the issues. |
|
@jlapeyre I see what you mean; I'm reasonably confident I have the changes from main, I think I will make a new PR with a new branch name that doesn't conflict, something like |
|
Obsolete. Replaced by #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170: minor changes because error handling for designators within this file wasn't standardized and should stay separated.