Configure clippy for dbg_macro and MSRV
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably not as good as checking compilation with the MSRV rustc. It can't check dependencies. But it will probably prevent using new features in this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses clippy to
Check for language constructs newer than a specified MSRV. The MSRV is set to 1.70.0.
Check for uses of
dbg!macro. These should be present neither on the main branch nor in releases of crates in this repo.This PR partially replaces Make debugging in release build a compiler error #43
#43 uses a custom macro to essential do what we do here. It is rather cumbersome and difficult to use across crates.
However #43 also defines
dprintln!which is likeprintln!but causes release builds to fail.