Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run slow tests for coverage only #317

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Run slow tests for coverage only #317

merged 3 commits into from
Jul 13, 2023

Conversation

caleb-johnson
Copy link
Collaborator

#307 includes a slow test that also provides important code coverage. I suggest we run slow tests on coverage only. This will allow us to continue to test a higher proportion of our code without bogging down every workflow with slow tests.

@caleb-johnson caleb-johnson added the cicd Related to the CICD pipeline label Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Pull Request Test Coverage Report for Build 5525586771

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.703%

Totals Coverage Status
Change from base Build 5523955804: 0.0%
Covered Lines: 2556
Relevant Lines: 2818

💛 - Coveralls

@garrison
Copy link
Member

I suggest we run slow tests on coverage only.

To clarify: this change makes it so coverage run the slow tests by default when invoked by tox; the other tox test environments don't run them. But within CI, the workflows explicitly opt for the other environments to run slow tests as well (see --run-slow in the test_*_versions.yml files). I think this is fine, just noting it.

@caleb-johnson caleb-johnson merged commit 9d46a36 into main Jul 13, 2023
9 checks passed
@caleb-johnson caleb-johnson deleted the slow branch July 13, 2023 19:07
@garrison
Copy link
Member

Coverage takes a long time to run now, as there is a single test (test_asymmetric_bitstrings_CN) that takes 39 seconds on my machine. I think it might be better to annotate the specific slow functions we actually want to count coverage for, and run only those slow tests during coverage. It might be annoying to figure out the details of this, but I'll probably do it one day when I am feeling especially annoyed by the status quo 🙂

@caleb-johnson
Copy link
Collaborator Author

Coverage takes a long time to run now, as there is a single test (test_asymmetric_bitstrings_CN) that takes 39 seconds on my machine. I think it might be better to annotate the specific slow functions we actually want to count coverage for, and run only those slow tests during coverage. It might be annoying to figure out the details of this, but I'll probably do it one day when I am feeling especially annoyed by the status quo 🙂

OK this had crossed my mind, but now that I see how bad the CN test is again, I'll look into it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Related to the CICD pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants