ci: Include distribution assets in each GitHub release #32
Conversation
Pull Request Test Coverage Report for Build 10841469671Details
💛 - Coveralls |
| @@ -40,6 +40,5 @@ jobs: | |||
| if: always() | |||
| uses: coverallsapp/github-action@v2 | |||
| with: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
This seems to be the default, as it seems to be safe to drop this line.
| with: | ||
| ref: ${{ github.ref_name }} |
There was a problem hiding this comment.
Likewise, not necessary to specify.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Python |
There was a problem hiding this comment.
Should specify Python 3.12 here explicitly. When Python 3.13 is released, there may be a short time before symengine wheels are available, and we don't want releases to fail in the meantime.
For this reason we really ought also to run this "build" step upon every push to main, as suggested in the pypa docs.
There was a problem hiding this comment.
Yes, those seem like reasonable ideas. Having this run on main should work if we loosen the run conditions at the top of this file but restrict the conditions for the second and third job in here.
This is only a draft for now. I still need to test it in a private repository.
References: