Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store circuit params automatically #1010

Merged
merged 13 commits into from
Aug 23, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Aug 9, 2023

Summary

Details and comments

Fixes #987

@coveralls
Copy link

coveralls commented Aug 9, 2023

Pull Request Test Coverage Report for Build 5954209661

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 74.058%

Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 2 81.37%
Totals Coverage Status
Change from base Build 5953027740: 0.0%
Covered Lines: 2458
Relevant Lines: 3319

💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Aug 21, 2023
@kt474 kt474 marked this pull request as ready for review August 22, 2023 19:34
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Two questions just for my understanding -

  1. Why did you add the kwargs parameter and not keep params or simply remove both?
    And why not remove the params in the creation of the RuntimeJob in QiskitRuntimeService?
  2. Why did you modify the SerializableClass.__eq__ method?

@kt474
Copy link
Member Author

kt474 commented Aug 23, 2023

  1. Why did you add the kwargs parameter and not keep params or simply remove both?
    And why not remove the params in the creation of the RuntimeJob in QiskitRuntimeService?
  2. Why did you modify the SerializableClass.__eq__ method?

You are right, removing params in the creation of the runtime job here is a much better approach - I was a bit backwards here (fixed). Since the params are no longer automatically a part of the runtime job, this custom serialization class returns {'value': 'foo'} which needs to be deserialized

@kt474 kt474 merged commit 15eb132 into Qiskit:main Aug 23, 2023
16 checks passed
@kt474 kt474 deleted the dont-store-circuit-params branch August 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit runner shouldn't store automatically store circuits in run jobs
3 participants