Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zachary's Karate Club #1280

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add Zachary's Karate Club #1280

wants to merge 27 commits into from

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Sep 9, 2024 •
edited
Loading

Adds the famous Zachary's karate club, a network that is used in many examples.

Makes #1277 easier and I assume it will be used in lots of example for community detection algorithms

@IvanIsCoding IvanIsCoding mentioned this pull request Sep 9, 2024
Draft
@IvanIsCoding IvanIsCoding changed the title Add Zachary's karate club Add Zachary's Karate Club Sep 9, 2024
@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11369009841

Details

  • 109 of 109 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.844%
Totals Coverage Status
Change from base Build 11366511038: 0.02%
Covered Lines: 18125
Relevant Lines: 18911
💛 - Coveralls

mtreinish
mtreinish reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM thanks for adding this generator. I just have a few inline comments that will slightly improve the performance and/or simplify the code.

rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Show resolved Hide resolved
rustworkx-core/src/generators/karate_club.rs Outdated Show resolved Hide resolved
tests/graph/test_karate.py Show resolved Hide resolved
src/generators.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderivrii alexanderivrii alexanderivrii left review comments

@mtreinish mtreinish Awaiting requested review from mtreinish

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanIsCoding @coveralls @mtreinish @alexanderivrii