Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #1290

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Oct 3, 2024

This is our yearly Python version maintenance. 3.8 reached EOL. I will add the newly released 3.13 in a separate PR to test the wheel release etc.

I profited to update black, ruff and mypy as well. mypy passes without any changes, but there were some minor differences with black and ruff.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11171426645

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.816%

Totals Coverage Status
Change from base Build 11153261135: 0.0%
Covered Lines: 17999
Relevant Lines: 18785

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm and it looks like is ci passing with the correct python versions. Thanks for doing this.

@@ -1,9 +1,6 @@
queue_rules:
- name: automerge
conditions:
- check-success=python3.8-x64 windows-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to push a PR to update this config with GitHub merge queues we don't need this, and we can only use mergify for automated backporting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. I actually quite like the GitHub queues, we could move some more expensive checks to the final merge instead of running them each time

@mtreinish mtreinish added this pull request to the merge queue Oct 4, 2024
Merged via the queue into Qiskit:main with commit c223d21 Oct 4, 2024
27 checks passed
@IvanIsCoding IvanIsCoding deleted the remove-38 branch October 4, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants