Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyo3 from 0.22.3 to 0.22.5 #1296

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2024

Bumps pyo3 from 0.22.3 to 0.22.4.

Release notes

Sourced from pyo3's releases.

PyO3 0.22.4

This release is a security fix for PyO3 0.22.0 through 0.22.3.

The PyWeakrefMethods trait functions for reading borrowed values from Python weak references have been identified as unsound, because they did not account for the possibility the last strong reference could be cleared at any time, leading the borrowed value to be dangling and risk of use-after-free.

PyO3 0.22.4 protects against this issue by making these methods permanently leak strong references. The methods are also marked deprecated and will be removed in PyO3 0.23. Users should switch to use the use PyWeakrefMethods functions which return owned references (the deprecation messages indicate the appropriate upgrade paths).

These functions were added in PyO3 0.22.0; all versions from 0.22.0 through 0.22.3 have been yanked.

Aside from the security fix, PyO3 0.22.4 contains a number of other bugfixes, including:

  • A fix for cases where __traverse__ functions of base types were not called when using #[pyclass(extends = ...)]
  • A fix for a regression in 0.22.3 where PyO3 generated code would trigger compile failures with crates using #![forbid(unsafe_code)]

Thank you to the following contributors for the improvements:

@​davidhewitt @​ngoldbaum @​exg @​Icxolu

Changelog

Sourced from pyo3's changelog.

[0.22.4] - 2024-10-12

Added

  • Add FFI definition PyWeakref_GetRef and compat::PyWeakref_GetRef. #4528

Changed

  • Deprecate _borrowed methods on PyWeakRef and PyWeakrefProxy (just use the owning forms). #4590

Fixed

  • Revert removal of private FFI function _PyLong_NumBits on Python 3.13 and later. #4450
  • Fix __traverse__ functions for base classes not being called by subclasses created with #[pyclass(extends = ...)]. #4563
  • Fix regression in 0.22.3 failing compiles under #![forbid(unsafe_code)]. #4574
  • Workaround possible use-after-free in _borrowed methods on PyWeakRef and PyWeakrefProxy by leaking their contents. #4590
  • Fix crash calling PyType_GetSlot on static types before Python 3.10. #4599
Commits
  • dff9723 release: 0.22.4
  • 3330bf2 fix garbage collection in inheritance cases (#4563)
  • 8b23397 ci: pypy 3.7 macos on x64 still
  • ce63713 ci: run benchmarks on ubuntu 22.04 (#4609)
  • b1173f5 ci: fix more ubuntu-24.04 failures (#4610)
  • 7371028 ci: move more jobs to macOS arm (#4600)
  • 8e3dc45 avoid calling PyType_GetSlot on static types before Python 3.10 (#4599)
  • 969300d leak references for safety in PyWeakRefMethods::upgrade_borrowed (#4590)
  • d01fbab fix case of gil-refs feature breaking create_exception! macro (#4589)
  • 9a641f7 fix unintentional unsafe_code trigger (#4574)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.22.3 to 0.22.4.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.22.3...v0.22.4)

---
updated-dependencies:
- dependency-name: pyo3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 15, 2024
@IvanIsCoding
Copy link
Collaborator

Not quite there, we need 0.22.5 not 0.22.4. The failing tests indicate that

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/pyo3-0.22.4 branch October 15, 2024 17:53
@IvanIsCoding IvanIsCoding restored the dependabot/cargo/pyo3-0.22.4 branch October 16, 2024 12:11
@IvanIsCoding IvanIsCoding reopened this Oct 16, 2024
@IvanIsCoding IvanIsCoding changed the title Bump pyo3 from 0.22.3 to 0.22.4 Bump pyo3 from 0.22.3 to 0.22.5 Oct 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11365590816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.82%

Totals Coverage Status
Change from base Build 11331963640: 0.0%
Covered Lines: 18016
Relevant Lines: 18802

💛 - Coveralls

@IvanIsCoding IvanIsCoding added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 8cc1286 Oct 16, 2024
26 checks passed
@IvanIsCoding IvanIsCoding deleted the dependabot/cargo/pyo3-0.22.4 branch October 16, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants