Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2 #49

Merged
merged 6 commits into from
Aug 18, 2024

Conversation

Cartrigger
Copy link
Collaborator

@Cartrigger Cartrigger commented Jun 30, 2024

Modmenu was not meant for non devmods, but because everyone is using devmods, we must remove from both, and these changes are confirmed working because they do not mess with Sodium in any way. The only issue would be double mod downloads, but because we are not replacing sodium, that should not matter.
These changes were tested before in my previous PR that got reverted because mod downloading doesn't work as it should.
Also removed 1.20.2

Copy link
Contributor

@thejudge156 thejudge156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pls

devmods.json Outdated Show resolved Hide resolved
mods.json Outdated Show resolved Hide resolved
@Cartrigger Cartrigger changed the title Remove Mod Menu and add optimization to 1.20.4 Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2 Aug 18, 2024
Copy link
Contributor

@thejudge156 thejudge156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran both through a json validator as well

@thejudge156 thejudge156 merged commit 1932f73 into QuestCraftPlusPlus:QuestCraft Aug 18, 2024
1 check failed
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants