-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2 #49
Merged
thejudge156
merged 6 commits into
QuestCraftPlusPlus:QuestCraft
from
Cart-shit:QuestCraft
Aug 18, 2024
Merged
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2 #49
thejudge156
merged 6 commits into
QuestCraftPlusPlus:QuestCraft
from
Cart-shit:QuestCraft
Aug 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejudge156
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix pls
Cartrigger
changed the title
Remove Mod Menu and add optimization to 1.20.4
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
Aug 18, 2024
thejudge156
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ran both through a json validator as well
CADIndie
pushed a commit
that referenced
this pull request
Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
CADIndie
pushed a commit
that referenced
this pull request
Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
CADIndie
pushed a commit
that referenced
this pull request
Oct 9, 2024
Remove Mod Menu and add optimization to 1.20.4, nuke 1.20.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modmenu was not meant for non devmods, but because everyone is using devmods, we must remove from both, and these changes are confirmed working because they do not mess with Sodium in any way. The only issue would be double mod downloads, but because we are not replacing sodium, that should not matter.
These changes were tested before in my previous PR that got reverted because mod downloading doesn't work as it should.
Also removed 1.20.2