Skip to content

Commit

Permalink
add analysis issue fix
Browse files Browse the repository at this point in the history
  • Loading branch information
eldrig0 committed Nov 22, 2024
1 parent fe43612 commit 3b9d51f
Show file tree
Hide file tree
Showing 97 changed files with 448 additions and 746 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,7 @@ app.*.map.json
/android/app/debug
/android/app/profile
/android/app/release


# FVM related
.fvmrc
233 changes: 0 additions & 233 deletions analysis_option.yaml

This file was deleted.

21 changes: 21 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
include: package:flutter_lints/flutter.yaml

analyzer:
errors:
close_sinks: ignore
missing_required_param: error
missing_return: error
# Ignored because of freezed and JsonKey (https://github.com/rrousselGit/freezed/issues/488)
invalid_annotation_target: ignore
body_might_complete_normally_nullable: ignore
depend_on_referenced_packages: ignore
avoid_function_literals_in_foreach_calls: ignore

exclude:
- test/.test_coverage.dart
- lib/generated_plugin_registrant.dart
- "**/*.g.dart"
- "**/*.freezed.dart"

linter:
rules:
4 changes: 2 additions & 2 deletions android/local.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
sdk.dir=/Users/marvin/Library/Android/sdk
flutter.sdk=/Users/marvin/flutter
sdk.dir=/Users/rinzin/Library/Android/sdk
flutter.sdk=/Users/rinzin/fvm/versions/3.24.0
2 changes: 1 addition & 1 deletion example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class _MyAppState extends State<MyApp> {
answerFormat: const BooleanAnswerFormat(
positiveAnswer: 'Yes',
negativeAnswer: 'No',
result: BooleanResult.POSITIVE,
result: BooleanResult.positive,
),
),
QuestionStep(
Expand Down
2 changes: 1 addition & 1 deletion example/linux/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1 @@
flutter/ephemeral
flutter/ephemeral/
4 changes: 2 additions & 2 deletions example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -703,10 +703,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
url: "https://pub.dev"
source: hosted
version: "14.2.5"
version: "14.2.4"
web:
dependency: transitive
description:
Expand Down
8 changes: 4 additions & 4 deletions ios/Flutter/Generated.xcconfig
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/marvin/flutter
FLUTTER_APPLICATION_PATH=/Users/marvin/repositories/survey_kit
FLUTTER_ROOT=/Users/rinzin/fvm/versions/3.24.0
FLUTTER_APPLICATION_PATH=/Users/rinzin/qbs/survey_kit
COCOAPODS_PARALLEL_CODE_SIGN=true
FLUTTER_TARGET=lib/main.dart
FLUTTER_BUILD_DIR=build
FLUTTER_BUILD_NAME=0.1.2
FLUTTER_BUILD_NUMBER=0.1.2
FLUTTER_BUILD_NAME=0.2.1
FLUTTER_BUILD_NUMBER=0.2.1
EXCLUDED_ARCHS[sdk=iphonesimulator*]=i386
EXCLUDED_ARCHS[sdk=iphoneos*]=armv7
DART_OBFUSCATION=false
Expand Down
8 changes: 4 additions & 4 deletions ios/Flutter/flutter_export_environment.sh
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
#!/bin/sh
# This is a generated file; do not edit or check into version control.
export "FLUTTER_ROOT=/Users/marvin/flutter"
export "FLUTTER_APPLICATION_PATH=/Users/marvin/repositories/survey_kit"
export "FLUTTER_ROOT=/Users/rinzin/fvm/versions/3.24.0"
export "FLUTTER_APPLICATION_PATH=/Users/rinzin/qbs/survey_kit"
export "COCOAPODS_PARALLEL_CODE_SIGN=true"
export "FLUTTER_TARGET=lib/main.dart"
export "FLUTTER_BUILD_DIR=build"
export "FLUTTER_BUILD_NAME=0.1.2"
export "FLUTTER_BUILD_NUMBER=0.1.2"
export "FLUTTER_BUILD_NAME=0.2.1"
export "FLUTTER_BUILD_NUMBER=0.2.1"
export "DART_OBFUSCATION=false"
export "TRACK_WIDGET_CREATION=true"
export "TREE_SHAKE_ICONS=false"
Expand Down
3 changes: 2 additions & 1 deletion lib/src/answer_format/agreement_answer_format.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ class AgreementAnswerFormat implements AnswerFormat {
final String? markdownAgreementText;

const AgreementAnswerFormat({
this.result = BooleanResult.NEGATIVE,
this.result = BooleanResult.negative,
this.defaultValue,
this.markdownDescription,
this.markdownAgreementText,
}) : super();

factory AgreementAnswerFormat.fromJson(Map<String, dynamic> json) =>
_$AgreementAnswerFormatFromJson(json);
@override
Map<String, dynamic> toJson() => _$AgreementAnswerFormatToJson(this);
}
10 changes: 5 additions & 5 deletions lib/src/answer_format/agreement_answer_format.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions lib/src/answer_format/boolean_answer_format.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ class BooleanAnswerFormat implements AnswerFormat {
const BooleanAnswerFormat({
required this.positiveAnswer,
required this.negativeAnswer,
this.result = BooleanResult.NONE,
this.result = BooleanResult.none,
this.defaultValue,
}) : super();

factory BooleanAnswerFormat.fromJson(Map<String, dynamic> json) =>
_$BooleanAnswerFormatFromJson(json);
@override
Map<String, dynamic> toJson() => _$BooleanAnswerFormatToJson(this);
}

enum BooleanResult { NONE, POSITIVE, NEGATIVE }
enum BooleanResult { none, positive, negative }
Loading

0 comments on commit 3b9d51f

Please sign in to comment.