Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate lambda parameters for uniqueness and add more tests #205

Merged
merged 7 commits into from
May 2, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Apr 29, 2024

adds lambdas into the mix for parameter uniqueness validation.

known issues:

  • names are not checked into lambdas (renaming a parameter of a top level method into a conflict with a parameter of an enclosed method will not throw an error)

fixes #188

@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend wip in progress labels Apr 29, 2024
@ix0rai
Copy link
Member Author

ix0rai commented Apr 30, 2024

names are not checked into lambdas (renaming a parameter of a top level method into a conflict with a parameter of an enclosed method will not throw an error)
should we even do this?

@ix0rai ix0rai changed the title start working on lambda validation validate lambda parameters for uniqueness and add more tests May 1, 2024
@ix0rai ix0rai removed the wip in progress label May 1, 2024
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ix0rai ix0rai merged commit c796230 into QuiltMC:master May 2, 2024
2 checks passed
@ix0rai ix0rai deleted the validate-lambdas branch May 2, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend affects the enigma backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate duplicate variable names for lambdas
2 participants